search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

chore: removed eslint-disable statements #646

Closed sohailfatima closed 5 months ago

sohailfatima commented 5 months ago

Description

Removed all unnecessary / unintentional eslint-disable statements, refactoring the code accordingly. No changes have been made to the functionality.

openedx-webhooks commented 5 months ago

Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

mphilbrick211 commented 5 months ago

Thank you for this contribution, @sohailfatima! Please let me know if you have any questions regarding submitting the CLA form. Thanks!

codecov[bot] commented 5 months ago

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (88a985d) 92.39% compared to head (f4d7f3e) 92.76%.

Files Patch % Lines
src/discussions/posts/data/slices.js 78.12% 14 Missing :warning:
src/discussions/post-comments/data/slices.js 95.65% 3 Missing :warning:
...iscussions/post-comments/comments/CommentsView.jsx 85.71% 1 Missing and 1 partial :warning:
src/discussions/data/slices.js 83.33% 1 Missing :warning:
src/discussions/topics/data/slices.js 85.71% 1 Missing :warning:
.../discussions/topics/topic-group/TopicGroupBase.jsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #646 +/- ## ========================================== + Coverage 92.39% 92.76% +0.37% ========================================== Files 169 156 -13 Lines 3456 3303 -153 Branches 896 902 +6 ========================================== - Hits 3193 3064 -129 + Misses 243 219 -24 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

awais-ansari commented 5 months ago

@sohailfatima Please rebase this branch.

awais-ansari commented 5 months ago

I'm closing this PR as @sohailfatima does not have the cla permission. We created a new PR for these Changes. 658

openedx-webhooks commented 5 months ago

@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.