openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

fix: updated css styling to prevent content spilling #652

Closed eemaanamir closed 5 months ago

eemaanamir commented 5 months ago

INF-891

Explanation

Styling for the code part of HTML has been added to prevent spilling out of the container.

Before Change:

Screenshot 2024-01-25 at 2 12 34 PM

After Change:

Screenshot 2024-01-25 at 2 13 36 PM
openedx-webhooks commented 5 months ago

Thanks for the pull request, @eemaanamir! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

mphilbrick211 commented 5 months ago

Hi @eemaanamir! Please let us know if you have any questions re: submitting a CLA form. Thanks!

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bb341df) 92.38% compared to head (649275f) 92.38%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #652 +/- ## ======================================= Coverage 92.38% 92.38% ======================================= Files 169 169 Lines 3452 3452 Branches 892 892 ======================================= Hits 3189 3189 Misses 243 243 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ayesha-waris commented 5 months ago

fixed in this PR -> INF-891-PR

openedx-webhooks commented 5 months ago

@eemaanamir Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.