search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 64 forks source link

fix: redirection to learners tab in inContext view #653

Closed sohailfatima closed 9 months ago

sohailfatima commented 10 months ago

INF-1224

Description

Fixed the issue of redirection to the learners tab within the inContext view when username is clicked from post details. The username in the inContext view is now simple text.

Before:

https://github.com/openedx/frontend-app-discussions/assets/68312464/43648b61-a146-4063-967c-d7841a0356fc

After:

https://github.com/openedx/frontend-app-discussions/assets/68312464/9182b0e5-0d42-48a1-a150-08aa9f12cc57

openedx-webhooks commented 10 months ago

Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

mphilbrick211 commented 10 months ago

Hi @sohailfatima! Thanks for this contribution! Please let me know if you have any questions regarding submitting a CLA form.

ayesha-waris commented 10 months ago

Please consider adding before and after screen recordings in description.

sohailfatima commented 10 months ago

@awais-ansari @ayesha-waris fixed the issue.

awais-ansari commented 10 months ago

@sohailfatima Please rebase the branch. The current branch has some conflicts.

mphilbrick211 commented 10 months ago

Hi @sohailfatima! I'm just following-up to see if you've had a chance to submit a CLA form?

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f69b2c1) 92.76% compared to head (60aa2b0) 92.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #653 +/- ## ======================================= Coverage 92.76% 92.76% ======================================= Files 156 156 Lines 3303 3304 +1 Branches 902 903 +1 ======================================= + Hits 3064 3065 +1 Misses 219 219 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ayesha-waris commented 9 months ago

fixed in PR

openedx-webhooks commented 9 months ago

@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.