openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 63 forks source link

feat: implemented error handling mockup #663

Closed sundasnoreen12 closed 7 months ago

sundasnoreen12 commented 7 months ago

INF-1100

Description

When a user navigates to a discussion board or a discussion post, they see an empty screen with indefinite loading in the following case:

  1. They are not enrolled in the course

Acceptance Criteria

We need to show a meaningful message to users instead of indefinite loading. Figma

Screenshots/sandbox (optional):

Screenshot 2024-02-12 at 6 46 27 PM

Merge Checklist

Post-merge Checklist

codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f0a4586) 92.76% compared to head (8aa935f) 92.81%.

Files Patch % Lines
...c/discussions/discussions-home/DiscussionsHome.jsx 88.23% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #663 +/- ## ========================================== + Coverage 92.76% 92.81% +0.05% ========================================== Files 156 158 +2 Lines 3303 3326 +23 Branches 905 915 +10 ========================================== + Hits 3064 3087 +23 Misses 219 219 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.