search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 63 forks source link

feat: modified TA icon according to role #664

Closed sohailfatima closed 7 months ago

sohailfatima commented 7 months ago

INF-737

Description

Modified TA icons to include tool-tips and add a moderator label. Corresponding backend PR: https://github.com/openedx/edx-platform/pull/34218

Before:

https://github.com/openedx/frontend-app-discussions/assets/68312464/e8c6fef1-3cb1-4720-92c7-3bb670b94342

After:

https://github.com/openedx/frontend-app-discussions/assets/68312464/b6c1559e-cf75-498c-a9e7-ef7457f4a83e

openedx-webhooks commented 7 months ago

Thanks for the pull request, @sohailfatima! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment here that you have signed it. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9eaed2b) 92.76% compared to head (a1275a5) 92.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #664 +/- ## ========================================== - Coverage 92.76% 92.76% -0.01% ========================================== Files 156 156 Lines 3304 3303 -1 Branches 903 905 +2 ========================================== - Hits 3065 3064 -1 Misses 219 219 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 7 months ago

hi @sohailfatima! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thanks!

ayesha-waris commented 7 months ago

hi @sohailfatima! Thank you for this contribution. Please let me know if you have any questions regarding submitting a CLA form. Thanks!

@mphilbrick211 fatima's CLA form has been submitted, but still have not received any update regarding it.

ehuthmacher commented 7 months ago

@sohailfatima I have not received your CLA form submission. Could you kindly resubmit the form?

ayesha-waris commented 7 months ago

created another PR due to CLA https://github.com/openedx/frontend-app-discussions/pull/665

openedx-webhooks commented 7 months ago

@sohailfatima Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

sohailfatima commented 7 months ago

@sohailfatima I have not received your CLA form submission. Could you kindly resubmit the form?

@ehuthmacher just submitted it for future contributions.

ehuthmacher commented 7 months ago

@sohailfatima Received, thank you. It is processing with our Legal department now.