openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

chore(deps): update paragon and frontend-build to openedx scope #666

Closed brian-smith-tcril closed 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.82%. Comparing base (3a7b705) to head (421ced1).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #666 +/- ## ======================================= Coverage 92.82% 92.82% ======================================= Files 158 158 Lines 3331 3331 Branches 919 919 ======================================= Hits 3092 3092 Misses 219 219 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brian-smith-tcril commented 4 months ago

it looks like this is likely a dupe of https://github.com/openedx/frontend-app-discussions/pull/657

arbrandes commented 4 months ago

This is now required for Tutor dev mode to work (see https://github.com/overhangio/tutor-mfe/pull/193). Should we merge this one or #657?

brian-smith-tcril commented 4 months ago

This is now required for Tutor dev mode to work (see overhangio/tutor-mfe#193). Should we merge this one or #657?

Looks like CI is failing on 657, I'll rebase this and see if it passes.

awais-ansari commented 4 months ago

@brian-smith-tcril @arbrandes This PR change has broken the stage and production pipeline for discussion MFE.

Screenshot 2024-02-29 at 1 47 28 PM
brian-smith-tcril commented 4 months ago

@awais-ansari it looks like you need to:

the brand-edx.org package shouldn't need to be updated

awais-ansari commented 4 months ago

@brian-smith-tcril Thanks for quick response. We have made some changes in internal and now build is green.