Closed brian-smith-tcril closed 4 months ago
it looks like this is likely a dupe of https://github.com/openedx/frontend-app-discussions/pull/657
This is now required for Tutor dev mode to work (see https://github.com/overhangio/tutor-mfe/pull/193). Should we merge this one or #657?
This is now required for Tutor dev mode to work (see overhangio/tutor-mfe#193). Should we merge this one or #657?
Looks like CI is failing on 657, I'll rebase this and see if it passes.
@brian-smith-tcril @arbrandes This PR change has broken the stage and production pipeline for discussion MFE.
@awais-ansari it looks like you need to:
frontend-component-header-edx
alias. 7.12.0
still has a peer dep of "@edx/frontend-platform": "^4.0.0 || ^5.0.0",
https://www.npmjs.com/package/@edx/frontend-component-header-edx/v/7.12.0?activeTab=code, and 7.21.2
(which I'd expect to be installed based on the ^
) has a peer dep of "@edx/frontend-platform": "^4.0.0 || ^5.0.0 || ^6.0.0",
https://www.npmjs.com/package/@edx/frontend-component-header-edx/v/7.21.2?activeTab=codefrontend-component-footer-edx
alias. 6.4.0
still has a peer dep of "@edx/frontend-platform": "^4.0.0 || ^5.0.0",
https://www.npmjs.com/package/@edx/frontend-component-footer-edx/v/6.4.0?activeTab=code, and 6.9.0
(what is being installed based on the ^
) has a peer dep of "@edx/frontend-platform": "^4.0.0 || ^5.0.0 || ^6.0.0",
https://www.npmjs.com/package/@edx/frontend-component-footer-edx/v/6.9.0?activeTab=codethe brand-edx.org
package shouldn't need to be updated
@brian-smith-tcril Thanks for quick response. We have made some changes in internal and now build is green.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #666 +/- ## ======================================= Coverage 92.82% 92.82% ======================================= Files 158 158 Lines 3331 3331 Branches 919 919 ======================================= Hits 3092 3092 Misses 219 219 Partials 20 20 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.