[BACKPORT] fix: redirection to learners tab in inContext view

dyudyunov commented 3 months ago

Description

This is a backport from the master (https://github.com/openedx/frontend-app-discussions/pull/659)

Changes were cherry-picked from the master branch. The only difference is that useShowLearnersTab is still taken into account (depends on the discussions.enable_learners_tab_in_discussions_mfe waffle flag in the LMS, removed in master).

fix: redirection to learners tab in inContext view. So a user can't navigate the site in the discussion sidebar
fix: changed username to simple text for in-context view
test: username is not clickable in in-context view

Steps to reproduce

ensure the discussions.enable_learners_tab_in_discussions_mfe is enabled (you should see the Learners tab in the discussions MFE)
ensure that discussions sidebar is enabled
open any unit in the Learning MFE containing the Discussions sidebar and create a new post
click on the new post and then click on author's username
observe the result

Actual result (before the fix)

A user is viewing the whole Discussion MFE page including the header, so they can navigate elsewhere (e.g. to the profile MFE)

Expected result (after the fix)

The username is just a text in the sidebar content, so no redirection is performed on click. No changes on the Discussions MFE - clicking on the username will show the user's posts.

Please check the original PR for video presentations before/after the fix.

Co-authored-by: sohailfatima 23100065@lums.edu.pk Co-authored-by: Fatima Sohail 68312464+sohailfatima@users.noreply.github.com Co-authored-by: Awais Ansari 79941147+awais-ansari@users.noreply.github.com

openedx-webhooks commented 3 months ago

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/quince.master@5ca0042). Click here to learn what that means.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## open-release/quince.master #680 +/- ## ============================================================= Coverage ? 92.43% ============================================================= Files ? 169 Lines ? 3451 Branches ? 898 ============================================================= Hits ? 3190 Misses ? 241 Partials ? 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dyudyunov commented 3 months ago

@sundasnoreen12 @awais-ansari please review

mphilbrick211 commented 3 months ago

@sundasnoreen12 @awais-ansari please review

Friendly ping on this @openedx/2u-infinity!

openedx-webhooks commented 3 months ago

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx / frontend-app-discussions