openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 64 forks source link

Add react-helmet to have the favico icon in production #685

Closed hinakhadim closed 8 months ago

hinakhadim commented 8 months ago

Description

When viewing discussion on Production, the app doesn't pick any link for favico.ico as it's link is set to null on start. On Researching in other MFEs, the other MFEs use react-helmet and set the favico.ico link on runtime. I believe we should do similar in this MFE so that favico can be viewed in production. So, I added react-helmet in this PR.

How Has This Been Tested?

I've tested it on my local system in development environment and have seen the react-data-helmet link tag for favico.ico

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After
Screenshot 2024-03-29 at 4 29 32 PM Screenshot 2024-03-29 at 4 30 35 PM

Merge Checklist

Post-merge Checklist