When viewing discussion on Production, the app doesn't pick any link for favico.ico as it's link is set to null on start. On Researching in other MFEs, the other MFEs use react-helmet and set the favico.ico link on runtime. I believe we should do similar in this MFE so that favico can be viewed in production. So, I added react-helmet in this PR.
How Has This Been Tested?
I've tested it on my local system in development environment and have seen the react-data-helmet link tag for favico.ico
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Before
After
Merge Checklist
[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
[ ] Is there adequate test coverage for your changes?
Post-merge Checklist
[ ] Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
Description
When viewing discussion on Production, the app doesn't pick any link for
favico.ico
as it's link is set to null on start. On Researching in other MFEs, the other MFEs usereact-helmet
and set thefavico.ico
link on runtime. I believe we should do similar in this MFE so thatfavico
can be viewed in production. So, I addedreact-helmet
in this PR.How Has This Been Tested?
I've tested it on my local system in development environment and have seen the
react-data-helmet
link tag forfavico.ico
Screenshots/sandbox (optional):
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.
Merge Checklist
Post-merge Checklist