It's possible to vote for your own posts in Discussions MFE

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 61 forks source link

It's possible to vote for your own posts in Discussions MFE #688

Closed DmytroAlipov closed 5 days ago

DmytroAlipov commented 3 months ago

The user has the opportunity to vote for his post:

But if you look at how it worked for Discussion XBlock, you can see that the ability to vote for your post is blocked and the button is not active for the user:

I found in the documentation that the user should not be able to vote for his post Discussions Docs

I found out that this resolution is obtained on the backend. But this is not used to Discussion MFE.

It might be worth paying attention to this.

DmytroAlipov commented 2 months ago

Hi @jmakowski1123. Perhaps you can suggest who works more closely with this MFE to consult on this issue. thanks in advance.

DmytroAlipov commented 2 months ago

Hi, @arbrandes. Are you involved in this type of MFE? It's just that this bug can be fixed in different ways. Ideally, this should be done on the frontend. By analogy with Legacy. This is much more difficult to do on the backend. Since all paths lead to the Forum service. I need an expert opinion before fixing this bug. I would appreciate your advice.

ayesha-waris commented 3 weeks ago

@DmytroAlipov Thanks for pointing out this bug, it will be resolved in this ticket

DmytroAlipov commented 3 weeks ago

Hi, @ayesha-waris Great news! I have a request when they open an MR in the upstream, please link this MR to it.

DmytroAlipov commented 3 weeks ago

@ayesha-waris Can we not close this search for now? Could you close this when the MR in the upstream is ready? Also, I have a question about the lack of information on this ticket. I don't have access to your Jira. That’s why I don’t know the state in which this ticket is located. Can you provide more information on this ticket? Also, I am wondering when you plan to work on it. Thanks 😊

ayesha-waris commented 3 weeks ago

@DmytroAlipov The ticket is in progress, I believe you will get notified once PR is shared for review as this issue will be mentioned in PR.

DmytroAlipov commented 1 day ago

Hi @ayesha-waris I’ve noticed that you’ve fixed the bug. This is indeed splendid news 🎉 I extend my deepest gratitude for your diligent efforts in making this correction.

If I may, I have an additional request. Would it be possible for you to create a backport to Redwood? Your assistance in this matter would be greatly appreciated. Thank you 😊