openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

fix: Discussions UI fixes on mobile resolutions #690

Closed Lunyachek closed 3 months ago

Lunyachek commented 3 months ago

This is backport from master PR - https://github.com/openedx/frontend-app-discussions/pull/689

Description

Fix user icon shrinkage

Before

Снимок экрана 2024-04-03 в 01 40 06 1

After

Снимок экрана 2024-04-03 в 01 53 42

Fix username overlapping with comment text, in cases when username is too long

Before

Снимок экрана 2024-04-03 в 01 45 22

After

Снимок экрана 2024-04-03 в 01 55 07

Added more space for long username by moving additional post data to the next row

Before

Снимок экрана 2024-04-03 в 01 48 05

After

Снимок экрана 2024-04-03 в 01 50 55

Fix sidebar width on tablet resolutions

On tablet resolutions, the sidebar becomes larger than on desktop. We believe this is illogical and fixed it

https://github.com/openedx/frontend-app-discussions/assets/19806032/3cacab34-76fa-454a-8911-43f68438860c

Before

Снимок экрана 2024-04-03 в 02 04 39

After

Снимок экрана 2024-04-03 в 02 04 54

Merge Checklist

Post-merge Checklist

openedx-webhooks commented 3 months ago

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/quince.master@efa0c1c). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/quince.master #690 +/- ## ============================================================= Coverage ? 92.43% ============================================================= Files ? 169 Lines ? 3451 Branches ? 898 ============================================================= Hits ? 3190 Misses ? 241 Partials ? 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openedx-webhooks commented 3 months ago

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.