feat: use frontend-plugin-framework to provide a FooterSlot

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.

GNU Affero General Public License v3.0

6 stars 64 forks source link

feat: use frontend-plugin-framework to provide a FooterSlot #698

Closed brian-smith-tcril closed 6 months ago

brian-smith-tcril commented 6 months ago

Description

Include a description of your changes here, along with a link to any relevant Jira tickets and/or GitHub issues.

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before	After

Merge Checklist

[ ] If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
[ ] Is there adequate test coverage for your changes?

Post-merge Checklist

[ ] Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
[ ] 🎉 🙌 Celebrate! Thanks for your contribution.

awais-ansari commented 6 months ago

The Discussion Forum is not working on stage. API calls are working fine. There is no code error in the console. We suspect that this PR might be a cause behind this issue. So, I'm reverting this PR.

awais-ansari commented 6 months ago

Discussion is working fine now after reverting this PR.

brian-smith-tcril commented 6 months ago

@awais-ansari is stage using a custom footer component?

edit: see below comment for updated plan

~~My assumption is that stage is using https://github.com/edx/frontend-component-footer-edx, in which case FooterSlot is not being provided by that package. There are 2 ways to go about solving this:~~

~~Port https://github.com/openedx/frontend-component-footer/pull/423 over to https://github.com/edx/frontend-component-footer-edx so the package provides FooterSlot~~
~~Utilize the FooterSlot and env.config.js in this MFE to replace the footer instead of relying on overriding the package.~~

brian-smith-tcril commented 6 months ago

We're working on a new pattern that will allow the footerslot to be shared while not requiring any updates to forked footers.

awais-ansari commented 6 months ago

@brian-smith-tcril good to hear that but we are not using any custom footer component. Today the same issue occurred on account MFE. The Stage was broken for account MFE. We need to update the testing approach.