search

openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 64 forks source link

Back button does not work from Discussion #703

Open mariajgrimaldi opened 6 months ago

mariajgrimaldi commented 6 months ago

Expected behavior

Clicking your browser's "back" button from the Discussion tab should take you to the previous page.

Steps to reproduce

  1. Start on any course page, such as https://apps.redwood.demo.edly.io/learning/course/course-v1:HinaX+HX101+2024_T2/home
  2. Click on "Discussion".
  3. Use your browser's back button.
  4. Witness a brief moment of "All posts sorted by recent activity" on the left.

The URL changes briefly from https://apps.redwood.demo.edly.io/discussions/course-v1:HinaX+HX101+2024_T2/posts to https://apps.redwood.demo.edly.io/discussions/course-v1:HinaX+HX101+2024_T2/ and then back to https://apps.redwood.demo.edly.io/discussions/course-v1:HinaX+HX101+2024_T2/posts

The original issue was reported on the BTR board as part of the redwood testing effort: https://github.com/openedx/wg-build-test-release/issues/346

mariajgrimaldi commented 6 months ago

FYI @arbrandes @brian-smith-tcril

mariajgrimaldi commented 6 months ago

Given the catalog-info.yml, I'll also tag you folks @openedx/2u-infinity here. Thanks!

ayesha-waris commented 5 months ago

@mariajgrimaldi I don't have access to the URLs mentioned in the issue report, but I tested on the edX production environment and couldn't reproduce the problem. The URL changes are from https://learning.edx.org/course/course-v1:edX+Inf101+2022/home To https://discussions.edx.org/course-v1:edX+Inf101+2022/posts Back to https://learning.edx.org/course/course-v1:edX+Inf101+2022/home Would you like me to try anything else?

mariajgrimaldi commented 5 months ago

@ayesha-waris: you can test here (redwood sandbox): https://redwood.demo.edly.io/ Here are the credentials: https://github.com/overhangio/openedx-release-demo?tab=readme-ov-file#open-edx-release-demo-platform-cd I'm not sure what's wrong, though. I tried this: /home -> /posts, but I can't get out of /posts in that installation. What version is edX using? Maybe it got fixed after the redwood cut.

ayesha-waris commented 5 months ago

@mariajgrimaldi tested on https://apps.redwood.demo.edly.io/learning/course/course-v1:OpenedX+DemoX+DemoCourse/home and it's working as expected. Can you please try clearing your chache. attaching GIF for reference chrome-capture-2024-6-12

mariajgrimaldi commented 3 months ago

I tested it again in a private window:

https://github.com/user-attachments/assets/ab6a1981-c499-41bc-a1ff-dc4d48923798

Can you use firefox? In Chrome, it seems to work.

mariajgrimaldi commented 2 months ago

Hi @ayesha-waris! Could you let me know if you could reproduce this using Firefox?