Open ihor-romaniuk opened 6 months ago
Thanks for the pull request, @ihor-romaniuk!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
This repository is currently maintained by @openedx/edx-infinity
. Tag them in a comment and let them know that your changes are ready for review.
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Hi @openedx/2u-infinity @openedx/edx-infinity! This, along with it's backport are ready for review. Thanks!
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment failed đĨ Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. đ Failure Logs âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment failed đĨ Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. đ Failure Logs âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.18%. Comparing base (
5e8c825
) to head (2e4b9dd
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Hi @openedx/2u-infinity - are you still maintaining this repo? If so, would you mind taking a look? Thanks!
Hi @openedx/2u-infinity - are you still maintaining this repo? If so, would you mind taking a look? Thanks!
Yes, We are still managing this repo. I'll review it.
@awais-ansari I believe everything is ready for merging of this pull request and of the backport pull request https://github.com/openedx/frontend-app-discussions/pull/705 as well. Could we proceed with that?
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
@awais-ansari: could you please help us merge this PR and the backport? Thanks!
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful đ đ LMS đ Studio âšī¸ Grove Config, Tutor Config, Tutor Requirements
@ihor-romaniuk Could you please rebase this PR?
Description
This merge request contains a fix for the comment edit block width at small screen resolutions for course Discussions pages or discussion sidebar in MFE Learning.
Related PR
Screenshots: