openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 64 forks source link

fix: block overflow when editing comment #706

Open ihor-romaniuk opened 6 months ago

ihor-romaniuk commented 6 months ago

Description

This merge request contains a fix for the comment edit block width at small screen resolutions for course Discussions pages or discussion sidebar in MFE Learning.

Related PR

Screenshots:

Before After
image image
openedx-webhooks commented 6 months ago

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

mphilbrick211 commented 6 months ago

Hi @openedx/2u-infinity @openedx/edx-infinity! This, along with it's backport are ready for review. Thanks!

open-craft-grove commented 5 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 3 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 3 months ago

Sandbox deployment failed đŸ’Ĩ Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. 📜 Failure Logs ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 3 months ago

Sandbox deployment failed đŸ’Ĩ Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. 📜 Failure Logs ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 3 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.18%. Comparing base (5e8c825) to head (2e4b9dd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #706 +/- ## ======================================= Coverage 93.18% 93.18% ======================================= Files 161 161 Lines 3404 3404 Branches 914 919 +5 ======================================= Hits 3172 3172 Misses 215 215 Partials 17 17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

open-craft-grove commented 3 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

mphilbrick211 commented 3 months ago

Hi @openedx/2u-infinity - are you still maintaining this repo? If so, would you mind taking a look? Thanks!

awais-ansari commented 2 months ago

Hi @openedx/2u-infinity - are you still maintaining this repo? If so, would you mind taking a look? Thanks!

Yes, We are still managing this repo. I'll review it.

ihor-romaniuk commented 2 months ago

@awais-ansari I believe everything is ready for merging of this pull request and of the backport pull request https://github.com/openedx/frontend-app-discussions/pull/705 as well. Could we proceed with that?

open-craft-grove commented 2 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 2 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 2 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

mariajgrimaldi commented 2 months ago

@awais-ansari: could you please help us merge this PR and the backport? Thanks!

open-craft-grove commented 1 month ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 1 month ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 1 month ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

awais-ansari commented 1 month ago

@ihor-romaniuk Could you please rebase this PR?