Open PKulkoRaccoonGang opened 5 months ago
Thanks for the pull request, @PKulkoRaccoonGang!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.
This repository is currently maintained by @openedx/edx-infinity
. Tag them in a comment and let them know that your changes are ready for review.
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.88%. Comparing base (
422fbf6
) to head (56f49c0
). Report is 8 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements
I'm not sure where the best place to report this issue is, but when visiting https://app.pr-724-6b242e.sandboxes.opencraft.hosting/discussions/course-v1:openedx+123+2023/posts/66879d5d57bfb4002db05e09 with a small window I noticed a visual bug
I remove the dark mode configuration to load only the Paragon light theme and avoid the reported issue.
C.C @PKulkoRaccoonGang @brian-smith-tcril
Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements
Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements
Hi @PKulkoRaccoonGang - can this be closed, or is it still in progress?
@mphilbrick211 this PR should stay open. The plan is to land it in a new long living branch for design tokens once it is updated to use a published version of Paragon that supports design tokens (which is getting really close!)
Sandbox deployment failed 💥 Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. 📜 Failure Logs ℹ️ Grove Config, Tutor Config, Tutor Requirements
Description
This pull request provides a sandbox for testing MFE runtime configurations.
Example config:
Info
Related PRs