openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 64 forks source link

feat: MFE runtime configuration API #724

Open PKulkoRaccoonGang opened 5 months ago

PKulkoRaccoonGang commented 5 months ago

Description

This pull request provides a sandbox for testing MFE runtime configurations.

Example config:

{
    "MFE_CONFIG_OVERRIDES": {
        "discussions": {
            "PARAGON_THEME_URLS": {
                "core": {
                    "urls": {
                        "default": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/core.min.css"
                    }
                },
                "defaults": {
                    "light": "light",
                },
                "variants": {
                    "light": {
                        "urls": {
                            "default": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/light.min.css"
                        }
                    }
                }
            }
        }
    }
}

Info

Related PRs

openedx-webhooks commented 5 months ago

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/edx-infinity. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.88%. Comparing base (422fbf6) to head (56f49c0). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #724 +/- ## ======================================= Coverage 92.88% 92.88% ======================================= Files 160 160 Lines 3329 3329 Branches 888 897 +9 ======================================= Hits 3092 3092 + Misses 219 218 -1 - Partials 18 19 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

open-craft-grove commented 5 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 4 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 4 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements

brian-smith-tcril commented 4 months ago

I'm not sure where the best place to report this issue is, but when visiting https://app.pr-724-6b242e.sandboxes.opencraft.hosting/discussions/course-v1:openedx+123+2023/posts/66879d5d57bfb4002db05e09 with a small window I noticed a visual bug

Screenshot from 2024-07-05 11-07-15

Screencast from 2024-07-05 11-07-00.webm

dcoa commented 4 months ago

I remove the dark mode configuration to load only the Paragon light theme and avoid the reported issue.

C.C @PKulkoRaccoonGang @brian-smith-tcril

open-craft-grove commented 4 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 4 months ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹ️ Grove Config, Tutor Config, Tutor Requirements

mphilbrick211 commented 4 weeks ago

Hi @PKulkoRaccoonGang - can this be closed, or is it still in progress?

brian-smith-tcril commented 4 weeks ago

@mphilbrick211 this PR should stay open. The plan is to land it in a new long living branch for design tokens once it is updated to use a published version of Paragon that supports design tokens (which is getting really close!)

open-craft-grove commented 4 weeks ago

Sandbox deployment failed 💥 Please check the settings and requirements. Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description. 📜 Failure Logs ℹ️ Grove Config, Tutor Config, Tutor Requirements