openedx / frontend-app-discussions

A React-based micro frontend for the Open edX discussion forums.
GNU Affero General Public License v3.0
6 stars 61 forks source link

testing: MFE runtime configuration API #724

Open PKulkoRaccoonGang opened 6 days ago

PKulkoRaccoonGang commented 6 days ago

Description

This pull request provides a sandbox for testing MFE runtime configurations.

Example config:

{
    "MFE_CONFIG_OVERRIDES": {
        "discussions": {
            "PARAGON_THEME_URLS": {
                "core": {
                    "urls": {
                        "default": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/core.min.css"
                    }
                },
                "defaults": {
                    "light": "light",
                    "dark": "dark"
                },
                "variants": {
                    "light": {
                        "urls": {
                            "default": "https://cdn.jsdelivr.net/npm/@openedx/paragon@$paragonVersion/dist/light.min.css"
                        }
                    },
                    "dark": {
                        "urls": {
                            "default": "https://cdn.jsdelivr.net/npm/@edx/brand-edx.org@alpha/dist/light.min.css"
                        }
                    }
                }
            }
        }
    }
}

Info

Related PRs

openedx-webhooks commented 6 days ago

Thanks for the pull request, @PKulkoRaccoonGang! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.88%. Comparing base (422fbf6) to head (a4cfa22).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #724 +/- ## ======================================= Coverage 92.88% 92.88% ======================================= Files 160 160 Lines 3329 3329 Branches 888 893 +5 ======================================= Hits 3092 3092 Misses 219 219 Partials 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

open-craft-grove commented 6 days ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 3 days ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove commented 2 days ago

Sandbox deployment successful 🚀 🎓 LMS 📝 Studio ℹī¸ Grove Config, Tutor Config, Tutor Requirements

brian-smith-tcril commented 1 day ago

I'm not sure where the best place to report this issue is, but when visiting https://app.pr-724-6b242e.sandboxes.opencraft.hosting/discussions/course-v1:openedx+123+2023/posts/66879d5d57bfb4002db05e09 with a small window I noticed a visual bug

Screenshot from 2024-07-05 11-07-15

Screencast from 2024-07-05 11-07-00.webm

dcoa commented 17 hours ago

I remove the dark mode configuration to load only the Paragon light theme and avoid the reported issue.

C.C @PKulkoRaccoonGang @brian-smith-tcril