openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

fix: build the course_id properly when MFE is deployed in a subdirectory #221

Closed jfavellar90 closed 2 years ago

jfavellar90 commented 2 years ago

This is a backport of https://github.com/edx/frontend-app-gradebook/pull/213

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

FYI: @edx/masters-devs-gta

openedx-webhooks commented 2 years ago

Thanks for the pull request, @jfavellar90! I've created OSPR-6326 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 2 years ago

@jfavellar90 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

natabene commented 2 years ago

@jfavellar90 @BbrSofiane Thank you!