openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

build: use shared browserslist config #243

Closed Jawayria closed 2 years ago

Jawayria commented 2 years ago

Removes custom browserslist configuration in favor of using a shared configuration. This change reduces the resultant asset bundle size.

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (da4e44b) compared to base (af2ece8). Patch has no changes to coverable lines.

:exclamation: Current head da4e44b differs from pull request most recent head e8b015f. Consider uploading reports for the commit e8b015f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #243 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 110 108 -2 Lines 1277 1259 -18 Branches 251 247 -4 ========================================= - Hits 1277 1259 -18 ``` | [Impacted Files](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [src/utils/StrictDict.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL3V0aWxzL1N0cmljdERpY3QuanM=) | `100.00% <0.00%> (ø)` | | | [src/components/GradesView/StatusAlerts.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9TdGF0dXNBbGVydHMuanN4) | `100.00% <0.00%> (ø)` | | | [src/components/GradesView/SearchControls.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9TZWFyY2hDb250cm9scy5qc3g=) | `100.00% <0.00%> (ø)` | | | [src/components/GradesView/EditModal/index.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9FZGl0TW9kYWwvaW5kZXguanN4) | `100.00% <0.00%> (ø)` | | | [src/components/GradesView/GradebookTable/index.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9pbmRleC5qc3g=) | `100.00% <0.00%> (ø)` | | | [...ponents/BulkManagementHistoryView/HistoryTable.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvQnVsa01hbmFnZW1lbnRIaXN0b3J5Vmlldy9IaXN0b3J5VGFibGUuanN4) | `100.00% <0.00%> (ø)` | | | [...nents/GradesView/EditModal/OverrideTable/index.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9FZGl0TW9kYWwvT3ZlcnJpZGVUYWJsZS9pbmRleC5qc3g=) | `100.00% <0.00%> (ø)` | | | [src/data/thunkActions/testUtils.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvdGh1bmtBY3Rpb25zL3Rlc3RVdGlscy5qcw==) | | | | [src/data/actions/testUtils.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/243/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvYWN0aW9ucy90ZXN0VXRpbHMuanM=) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Jawayria commented 2 years ago

Frontend Bom will be carrying these forward. cc: @abdullahwaheed

openedx-webhooks commented 2 years ago

Thanks for the pull request, @Jawayria! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

natabene commented 2 years ago

This looks like an internal PR, is anyone working on this?

abdullahwaheed commented 2 years ago

@natabene yes @Mashal-m is part of @openedx/fed-bom and we are working on this PR. Once her credentials are created, we'll proceed further

natabene commented 2 years ago

@abdullahwaheed Great. Please note that @Mashal-m will need to be onboarded by the 2U HelpDesk, so she doesn't need to sign the CLA. Please work with 2U HelpDesk to expedite the process. Also, this PR will forever be flagged anyway, if original author is no longer working for 2U. So you can either just override and merge regardless, if you can. If not, @Mashal-m will need to re-open this work in a new PR under her name, once she has been onboarded by HelpDesk.

openedx-webhooks commented 2 years ago

@Jawayria Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.