Closed BilalQamar95 closed 1 year ago
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:
Coverage data is based on head (
a9d7878
) compared to base (85607d7
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
We would much rather exclude some of these new and not-agreed-on eslint rules than update the style for our whole repo. If there are new-mismatching rules, please set up ignores for them and create a ticket for us to review the new eslint rules.
@BilalQamar95, looks like @muselesscreator requested some changes. Can we update the eslint rules for this repo to make the PR more palatable?
@BilalQamar95, looks like @muselesscreator requested some changes. Can we update the eslint rules for this repo to make the PR more palatable?
@arbrandes, the comment from @muselesscreator triggered a thread on edx internal slack in result of which there was a PR merged disabling some rules that were deemed unnecessary. This PR was updated afterwards, in light of those changes. If there are still new or not-agreed-on eslint rules in the PR I would be happy to revise those.
@BilalQamar95, thanks for the update! Can you please fix the conflicts so we can merge this?
@muselesscreator, mind giving us the green light officially? If you're not available or don't have time, we'll go ahead and merge it.
@arbrandes I have resolved all the merge conflicts.
TL;DR - [Eslint was updated in
frontend-build
version resulting in it's version being bumped to v12. In order to reciprocate eslint version update, this PR updatedfrontend-build
version to v12.0.0.]GIT Ticket: 42: Upgrade eslint to v8.x
What changed?
frontend-build
to v12eslint
issuesDeveloper Checklist
Testing Instructions
[ How should a reviewer test this PR? ]
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora