openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

refactor: upgraded frontend-build version to v12 #254

Closed BilalQamar95 closed 1 year ago

BilalQamar95 commented 2 years ago

TL;DR - [Eslint was updated in frontend-build version resulting in it's version being bumped to v12. In order to reciprocate eslint version update, this PR updated frontend-build version to v12.0.0.]

GIT Ticket: 42: Upgrade eslint to v8.x

What changed?

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

FYI: @openedx/content-aurora

codecov[bot] commented 2 years ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (a9d7878) compared to base (85607d7). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #254 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 109 109 Lines 1265 1264 -1 Branches 248 248 ========================================= - Hits 1265 1264 -1 ``` | [Impacted Files](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...rc/components/GradesView/GradebookTable/Fields.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9GaWVsZHMuanN4) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/app.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvYXBwLmpz) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/assignmentTypes.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvYXNzaWdubWVudFR5cGVzLmpz) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/cohorts.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvY29ob3J0cy5qcw==) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/config.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvY29uZmlnLmpz) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/filters.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvZmlsdGVycy5qcw==) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/grades.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvZ3JhZGVzLmpz) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/roles.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvcm9sZXMuanM=) | `100.00% <100.00%> (ø)` | | | [src/data/reducers/tracks.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/254?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdWNlcnMvdHJhY2tzLmpz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

muselesscreator commented 2 years ago

We would much rather exclude some of these new and not-agreed-on eslint rules than update the style for our whole repo. If there are new-mismatching rules, please set up ignores for them and create a ticket for us to review the new eslint rules.

arbrandes commented 1 year ago

@BilalQamar95, looks like @muselesscreator requested some changes. Can we update the eslint rules for this repo to make the PR more palatable?

BilalQamar95 commented 1 year ago

@BilalQamar95, looks like @muselesscreator requested some changes. Can we update the eslint rules for this repo to make the PR more palatable?

@arbrandes, the comment from @muselesscreator triggered a thread on edx internal slack in result of which there was a PR merged disabling some rules that were deemed unnecessary. This PR was updated afterwards, in light of those changes. If there are still new or not-agreed-on eslint rules in the PR I would be happy to revise those.

arbrandes commented 1 year ago

@BilalQamar95, thanks for the update! Can you please fix the conflicts so we can merge this?

@muselesscreator, mind giving us the green light officially? If you're not available or don't have time, we'll go ahead and merge it.

BilalQamar95 commented 1 year ago

@arbrandes I have resolved all the merge conflicts.