feat: add a simple validation to the adjusted grade field

openedx / frontend-app-gradebook

Instructor grade book tool

GNU Affero General Public License v3.0

11 stars 87 forks source link

feat: add a simple validation to the adjusted grade field #264

Closed ihor-romaniuk closed 1 year ago

ihor-romaniuk commented 2 years ago

TL;DR - added simple validation for the "Adjusted grade" field in the "Edit Grades" popup:

enter only a numeric value
setting the minimum value
checking the correctness of the entered value to possibleGrade

FYI: @openedx/content-aurora

openedx-webhooks commented 2 years ago

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

natabene commented 2 years ago

@ihor-romaniuk Thank you for your contribution. Is this ready for our review?

ihor-romaniuk commented 2 years ago

@ihor-romaniuk Thank you for your contribution. Is this ready for our review?

Yes, everything is ready for review.

ProductRyan commented 1 year ago

Internal tracking JIRA ticket: https://2u-internal.atlassian.net/browse/AU-945

ihor-romaniuk commented 1 year ago

Why add this validation on top of adding the min/max to the component?

Input attributes min/max validate value which was changed by input number controls but it doesn't validate key entering. So an additional validation in the onChange method was created for validation value from the keyboard.

mphilbrick211 commented 1 year ago

Flagging this for follow-up @muselesscreator!

ProductRyan commented 1 year ago

@ihor-romaniuk can you describe or show the change the user experience with this feature?

mphilbrick211 commented 1 year ago

Hi @ihor-romaniuk! Friendly ping on Ryan's question above.

openedx-webhooks commented 1 year ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.