openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

fix: add an asterisk to the 'Email' name of column #270

Closed ihor-romaniuk closed 1 year ago

ihor-romaniuk commented 2 years ago

TL;DR - I suggest adding the * sign to the email column name to identify that its data is available for masters track only (like for the "student key"). Because the grades API code says that the data for that column only available for the masters mode.

image
openedx-webhooks commented 2 years ago

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

leangseu-edx commented 2 years ago

LGTM 👍

ihor-romaniuk commented 1 year ago

@jansenk @leangseu-edx Who can help with merging these changes, because we have an approved and hung PR?

ihor-romaniuk commented 1 year ago

@natabene Could you help us manage to merge this PR, please?

openedx-webhooks commented 1 year ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.