openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

Feature: Persian language Support #279

Closed CodeWithEmad closed 1 year ago

CodeWithEmad commented 2 years ago

TL;DR - [ A short summary of what this PR does and why ]

Hello everyone I'm glad to announce that we translated all openedx components in transifex to Persian and fa_IR is 100% translated and 100% reviewed.

What changed?

in this PR, I've added: new translations to i18n/messages/fa_IR.json, fa-ir in messages in src/i18n/index.js, and fa_IR code in transifex_langs variable in Makefile.

is there anything else I should do?

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

FYI: @openedx/content-aurora

openedx-webhooks commented 2 years ago

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

mphilbrick211 commented 1 year ago

Hi @CodeWithEmad - apologies for the delay on this. I will check in on getting this reviewed. In the meantime, would you mind resolving the branch conflicts?

CC: @openedx/content-aurora @mattcarter

mphilbrick211 commented 1 year ago

Hi @CodeWithEmad! Would you mind resolving the branch conflicts?

CC: @mattcarter @openedx/content-aurora for merging (as owners of the repo). Thanks!

CodeWithEmad commented 1 year ago

Hi @mphilbrick211. sorry for the delay. all conflicts resolved.

CodeWithEmad commented 1 year ago

also @mphilbrick211 I've added persian langauge support to frontend

CodeWithEmad commented 1 year ago

@mphilbrick211 in the https://github.com/openedx/frontend-platform/pull/385, I've added Persian language support to the frontend-platform repo also. but looks like they forgot to review/merge it. that PR was created in October 2022! :)

e0d commented 1 year ago

@CodeWithEmad I've run the tests and there's a commit lint issue:

⧗   input: reformat: reorder imports alphabetically
✖   type must be one of [revert, feat, fix, perf, docs, test, build, refactor, style, chore, temp] [type-enum]

Can this PR merge prior to https://github.com/openedx/frontend-platform/pull/385? I realize it won't work, but was curious if it would break anything.

codecov[bot] commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (6a21c11) compared to base (d0ab0ec). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 109 109 Lines 1260 1260 Branches 248 248 ========================================= Hits 1260 1260 ``` | [Impacted Files](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [src/i18n/index.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/279?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2kxOG4vaW5kZXguanN4) | `100.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

CodeWithEmad commented 1 year ago

@CodeWithEmad I've run the tests and there's a commit lint issue:

oops. my bad. commit type changed to refactor.

Can this PR merge prior to openedx/frontend-platform#385? I realize it won't work, but was curious if it would break anything.

No, it won't break anything. the only issue here is that the frontend platform doesn't recognize fa-ir code as an RTL language, and it will show the translations from Left to Right. which will be fixed, when they merge that MR.

e0d commented 1 year ago

@CodeWithEmad excellent, all green now.

openedx-webhooks commented 1 year ago

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.