openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

fix: Fix rows counter in the Edit Grade modal window (olive branch) #311

Closed Lunyachek closed 1 year ago

Lunyachek commented 1 year ago

TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting

Снимок экрана 2023-02-10 в 15 25 06

What changed?

Снимок экрана 2023-02-10 в 15 42 01

FYI: @openedx/content-aurora

openedx-webhooks commented 1 year ago

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

mphilbrick211 commented 1 year ago

Hi @Lunyachek! Is this duplicate of #310?

mphilbrick211 commented 1 year ago

Hi @Lunyachek! Is this duplicate of #310?

@Lunyachek Nevermind - I see the different titles. :)

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (open-release/olive.master@85709d9). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/olive.master #311 +/- ## ============================================================= Coverage ? 100.00% ============================================================= Files ? 109 Lines ? 1272 Branches ? 252 ============================================================= Hits ? 1272 Misses ? 0 Partials ? 0 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mphilbrick211 commented 1 year ago

Hi @mattcarter - just following up on this for review/merge. Thanks!

mphilbrick211 commented 1 year ago

Hi @mattcarter - just following up on this for review/merge. Thanks!

My apologies @mattcarter - it looks like Product needs to review first. CC: @jmakowski1123 @ProductRyan

jmakowski1123 commented 1 year ago

Since this fix has multiple PRs associated with it (https://github.com/openedx/frontend-app-gradebook/pull/310 and https://github.com/openedx/frontend-app-gradebook/pull/311), I've created a Product Feature ticket. It's currently undergoing Product Review in that Product Feature Ticket.

mphilbrick211 commented 1 year ago

Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!

mphilbrick211 commented 1 year ago

Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!

Hi @mattcarter - friendly ping on this :)

mphilbrick211 commented 1 year ago

HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks!

mphilbrick211 commented 1 year ago

HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks!

Just checking in on this @openedx/content-aurora :)

openedx-webhooks commented 1 year ago

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.