Closed Lunyachek closed 1 year ago
Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hi @Lunyachek! Is this duplicate of #310?
Hi @Lunyachek! Is this duplicate of #310?
@Lunyachek Nevermind - I see the different titles. :)
:exclamation: No coverage uploaded for pull request base (
open-release/olive.master@85709d9
). Click here to learn what that means. Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @mattcarter - just following up on this for review/merge. Thanks!
Hi @mattcarter - just following up on this for review/merge. Thanks!
My apologies @mattcarter - it looks like Product needs to review first. CC: @jmakowski1123 @ProductRyan
Since this fix has multiple PRs associated with it (https://github.com/openedx/frontend-app-gradebook/pull/310 and https://github.com/openedx/frontend-app-gradebook/pull/311), I've created a Product Feature ticket. It's currently undergoing Product Review in that Product Feature Ticket.
Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!
Hi @mattcarter @openedx/content-aurora! This is ready for your review. If all looks good, please merge as well. Thank you!
Hi @mattcarter - friendly ping on this :)
HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks!
HIi @mattcarter and @openedx/content-aurora! Would it be possible for someone to review/merge this? Thanks!
Just checking in on this @openedx/content-aurora :)
@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
TL;DR - The problem was in the rows counter in the Edit Grades modal window. First digit - number of lines excluding the last line with the form. Second digit - grades data. And our proposal is to include last row with form to common counting
What changed?
FYI: @openedx/content-aurora