openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: upgraded to node v18, added .nvmrc and updated workflows #317

Closed BilalQamar95 closed 1 year ago

BilalQamar95 commented 1 year ago

Ticket

Upgrade Node Js from 16 to 18

Description

edx-internal PR

https://github.com/edx/edx-internal/pull/8338 This needs to be merged together.

Developer Checklist

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

FYI: @openedx/content-aurora

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -4.56 :warning:

Comparison is base (ae1702d) 100.00% compared to head (0f5fd7d) 95.44%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #317 +/- ## =========================================== - Coverage 100.00% 95.44% -4.56% =========================================== Files 123 124 +1 Lines 1274 1338 +64 Branches 250 271 +21 =========================================== + Hits 1274 1277 +3 - Misses 0 53 +53 - Partials 0 8 +8 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/317/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

abdullahwaheed commented 1 year ago

@muselesscreator could you please review it again