openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: add column for full name for masters students #321

Closed jansenk closed 1 year ago

jansenk commented 1 year ago

TL;DR - Add column for full name

JIRA: AU-218

FYI: @openedx/content-aurora

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (541a661) 100.00% compared to head (48d0965) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #321 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 122 122 Lines 1269 1274 +5 Branches 251 250 -1 ========================================= + Hits 1269 1274 +5 ``` | [Impacted Files](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...c/components/GradesView/GradebookTable/messages.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9tZXNzYWdlcy5qcw==) | `100.00% <ø> (ø)` | | | [...rc/components/GradesView/GradebookTable/Fields.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9GaWVsZHMuanN4) | `100.00% <100.00%> (ø)` | | | [...ts/GradesView/GradebookTable/LabelReplacements.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9MYWJlbFJlcGxhY2VtZW50cy5qc3g=) | `100.00% <100.00%> (ø)` | | | [src/components/GradesView/GradebookTable/index.jsx](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9pbmRleC5qc3g=) | `100.00% <100.00%> (ø)` | | | [src/data/constants/grades.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvY29uc3RhbnRzL2dyYWRlcy5qcw==) | `100.00% <100.00%> (ø)` | | | [src/data/selectors/grades.js](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvc2VsZWN0b3JzL2dyYWRlcy5qcw==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://codecov.io/gh/openedx/frontend-app-gradebook/pull/321/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jansenk commented 1 year ago

Screenshot 2023-04-21 at 12 11 52 PM

jansenk commented 1 year ago

While it wasn't technically specified as an AC, the ticket mentions an additional piece of work that is missing:

  • default front-end disabled for large (ie, 100+ learners)

Ryan's most recent comment on the ticket says

hey friends. after a discussion with Mat I think we should replicate the functionality and visibility of the email field for >master-track users.

i.e. only show the name data for master-track seats

This was a day after the text of the ticket was updated. I took this to mean that we were no longer doing the 100 student limit. I'll check with Ryan

jansenk commented 1 year ago

I'll check with Ryan

Ryan confirmed that this is the desired behavior