search

openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: added "Get Feedback" widget #322

Closed jszewczulak closed 1 year ago

jszewczulak commented 1 year ago

TL;DR - "Get Feedback" Widget added to Gradebook

JIRA: AU-1122

What changed?

Screenshot 2023-04-25 at 9 25 27 AM

FYI: @openedx/content-aurora

openedx-webhooks commented 1 year ago

Thanks for the pull request, @jszewczulak! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (541a661) 100.00% compared to head (25e230d) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #322 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 122 122 Lines 1269 1269 Branches 251 251 ========================================= Hits 1269 1269 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mphilbrick211 commented 1 year ago

Hi @jszewczulak! Are you submitting this as part of 2U? If so, please check with your manager about getting added as a contributor to the entity CLA agreement they have with us (Axim). Then, when you re-run the tests, that CLA check should turn green. Thanks!

jszewczulak commented 1 year ago

Yes, I joined 2U recently and there are still issues with my github permissions to commit to openedx directly, hence this workaround. I will have my teammates review this PR. Thanks, Jakub

On Wed, Apr 26, 2023 at 1:03 PM Michelle Philbrick @.***> wrote:

Hi @jszewczulak https://github.com/jszewczulak! Are you submitting this as part of 2U? If so, please check with your manager about getting added as a contributor to the entity CLA agreement they have with us (Axim). Then, when you re-run the tests, that CLA check should turn green. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/openedx/frontend-app-gradebook/pull/322#issuecomment-1523766161, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6W7LV7AFL5RENTUAZXWBPTXDFINVANCNFSM6AAAAAAXMSX5D4 . You are receiving this because you were mentioned.Message ID: @.***>

mattcarter commented 1 year ago

Hi @mphilbrick211 - @jszewczulak is a new 2U employee and his access is in-process. I've asked him to post a PR as a first step to keep him moving forward. I'm going to ask him to change this to a draft PR and we can discuss code, but not merge until all the access paperwork settles.

mphilbrick211 commented 1 year ago

Hi @mphilbrick211 - @jszewczulak is a new 2U employee and his access is in-process. I've asked him to post a PR as a first step to keep him moving forward. I'm going to ask him to change this to a draft PR and we can discuss code, but not merge until all the access paperwork settles.

Thank you!

jmakowski1123 commented 1 year ago

@jszewczulak Who is the product manager at 2U that "owns" this feature?

jszewczulak commented 1 year ago

Hi Jenna, That would be Daniel Silber-Baker. If it makes things easier, today I have received an invite to join openedex github org. I can close this PR and create a new one in openedex directly. Please advise. Thanks, Jakub

On Wed, May 3, 2023 at 3:00 PM Jenna Makowski @.***> wrote:

@jszewczulak https://github.com/jszewczulak Who is the product manager at 2U that "owns" this feature?

— Reply to this email directly, view it on GitHub https://github.com/openedx/frontend-app-gradebook/pull/322#issuecomment-1533548501, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6W7LV3FWEXKHL4ZVG5K3UTXEKTMTANCNFSM6AAAAAAXMSX5D4 . You are receiving this because you were mentioned.Message ID: @.***>

jmakowski1123 commented 1 year ago

@Daniel-hershel is going to take the lead on creating a Feature Ticket for this. Then whenever the PR is ready to be recreated in the openedx org, it can be linked to the Feature Ticket with all the relevant product info.

jszewczulak commented 1 year ago

Now that I received permissions to commit to openedx directly I'm closing this PR and opening a new one directly in openedx org.