openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: don't show masters-only columns for courses without a masters track #324

Open jansenk opened 1 year ago

jansenk commented 1 year ago

Only show masters-only columns when a course has a master's track.

No Masters track / mode:

Screenshot 2023-05-08 at 3 36 48 PM Screenshot 2023-05-08 at 3 41 27 PM

Masters track / mode

Screenshot 2023-05-08 at 3 35 49 PM Screenshot 2023-05-08 at 3 35 55 PM

Note: This is based on TRACKS. As shown in the screenshot above, you can technically have a student who is enrolled as "masters" without a masters track in a course BUT this is only possible through manual developer modification and can't happen in normal user-facing environments.

FYI: @openedx/content-aurora

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (6778948) to head (32be24c). Report is 51 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #324 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 122 122 Lines 1274 1281 +7 Branches 250 253 +3 ========================================= + Hits 1274 1281 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

farhaanbukhsh commented 1 week ago

@mphilbrick211 This will require a proposal.

@jansenk Are you willing to pursue these changes?