openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: use `atlas` in `make pull_translations` #325

Closed OmarIthawi closed 1 year ago

OmarIthawi commented 1 year ago

Changes

Testing

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

FYI: @openedx/content-aurora

References

This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:

Breaking Changes

One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:

For Micro-frontends:

openedx-webhooks commented 1 year ago

Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6778948) 100.00% compared to head (3dc9212) 100.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #325 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 122 123 +1 Lines 1274 1274 Branches 250 250 ========================================= Hits 1274 1274 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...iew/EditModal/OverrideTable/AdjustedGradeInput.jsx](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9FZGl0TW9kYWwvT3ZlcnJpZGVUYWJsZS9BZGp1c3RlZEdyYWRlSW5wdXQuanN4) | `100.00% <ø> (ø)` | | | [src/components/GradesView/GradebookTable/index.jsx](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9HcmFkZWJvb2tUYWJsZS9pbmRleC5qc3g=) | `100.00% <ø> (ø)` | | | [src/data/selectors/grades.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvc2VsZWN0b3JzL2dyYWRlcy5qcw==) | `100.00% <ø> (ø)` | | | [src/index.jsx](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | | | [src/i18n/index.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2kxOG4vaW5kZXguanM=) | `100.00% <100.00%> (ø)` | | | [src/i18n/utils.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/325?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2kxOG4vdXRpbHMuanM=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

brian-smith-tcril commented 1 year ago

@OmarIthawi looks like this has conflicts again. @mphilbrick211 this repo is still listed as "Need edX answer" on the spreadsheet. Is there someone specific I should tag on this so Omar doesn't need to keep updating this PR to resolve conflicts?

brian-smith-tcril commented 1 year ago

@OmarIthawi looks like tests are failing on this one now, are they passing locally for you?

OmarIthawi commented 1 year ago

@OmarIthawi looks like tests are failing on this one now, are they passing locally for you?

no, they aren't. I'm working on fixing them.

OmarIthawi commented 1 year ago

Now tests are fixed. cc: @brian-smith-tcril

brian-smith-tcril commented 1 year ago

@mattcarter this one should be good to go!

openedx-webhooks commented 1 year ago

@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.