search

openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

Bw/component modernization #331

Closed muselesscreator closed 1 year ago

muselesscreator commented 1 year ago

TL;DR - This PR modernizes the components within the GradesView component directory to hook components, and loads their redux data through new redux hooks.

Tech proposal doc: https://docs.google.com/document/d/19YwqYu_sRZZk_N4O_sfBU5OwJnEm8YDinfUzbwe-A78/edit

JIRA: AU-1212

Developer Checklist

Testing Instructions

Smoke test of GradesView functionality

Collectively, these should be completed by reviewers of this PR:

FYI: @openedx/content-aurora

nsprenkle commented 1 year ago

Please resolve conflicts and update PR description to remove empty boilerplate before any walkthroughs happen.

nsprenkle commented 1 year ago

What would help me is to have a toy example in the description of what, "modernizes the components within the GradesView component directory to hook components, and loads their redux data through new redux hooks." looks like.

As someone who has not done these style of refactors, that is effectively useless information to me without an example 🙃

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 97.60% and project coverage change: -0.51 :warning:

Comparison is base (ffecce9) 95.44% compared to head (8e19b57) 94.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #331 +/- ## ========================================== - Coverage 95.44% 94.93% -0.51% ========================================== Files 124 139 +15 Lines 1338 1343 +5 Branches 271 264 -7 ========================================== - Hits 1277 1275 -2 - Misses 53 60 +7 Partials 8 8 ``` | [Impacted Files](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...ents/GradesView/BulkManagementControls/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9CdWxrTWFuYWdlbWVudENvbnRyb2xzL21lc3NhZ2VzLmpz) | `100.00% <ø> (ø)` | | | [...components/GradesView/FilterMenuToggle/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9GaWx0ZXJNZW51VG9nZ2xlL21lc3NhZ2VzLmpz) | `100.00% <ø> (ø)` | | | [...mponents/GradesView/ImportSuccessToast/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9JbXBvcnRTdWNjZXNzVG9hc3QvbWVzc2FnZXMuanM=) | `100.00% <ø> (ø)` | | | [...ponents/GradesView/InterventionsReport/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9JbnRlcnZlbnRpb25zUmVwb3J0L21lc3NhZ2VzLmpz) | `100.00% <ø> (ø)` | | | [...c/components/GradesView/ScoreViewInput/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9TY29yZVZpZXdJbnB1dC9tZXNzYWdlcy5qcw==) | `100.00% <ø> (ø)` | | | [...c/components/GradesView/SearchControls/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9TZWFyY2hDb250cm9scy9tZXNzYWdlcy5qcw==) | `100.00% <ø> (ø)` | | | [src/components/GradesView/StatusAlerts/messages.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2NvbXBvbmVudHMvR3JhZGVzVmlldy9TdGF0dXNBbGVydHMvbWVzc2FnZXMuanM=) | `100.00% <ø> (ø)` | | | [src/data/redux/hooks/thunkActions.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvcmVkdXgvaG9va3MvdGh1bmtBY3Rpb25zLmpz) | `100.00% <ø> (ø)` | | | [src/data/services/lms/urls.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvc2VydmljZXMvbG1zL3VybHMuanM=) | `95.00% <50.00%> (-5.00%)` | :arrow_down: | | [src/utils/formatDate.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL3V0aWxzL2Zvcm1hdERhdGUuanM=) | `50.00% <50.00%> (ø)` | | | ... and [41 more](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/331?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.