Closed dcoa closed 1 year ago
Thanks for the pull request, @dcoa! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Patch coverage: 100.00%
and no project coverage change.
Comparison is base (
44197f6
) 94.93% compared to head (e10ef6d
) 94.93%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @mphilbrick211 we are facing the same issue while running the gradebook locally and on a server. Is it possible by any chance that the review on this PR could be prioritized?
Hey @mphilbrick211 we are facing the same issue while running the gradebook locally and on a server. Is it possible by any chance that the review on this PR could be prioritized?
Hi @openedx/content-aurora! Flagging this - would someone be able to please review?
@muselesscreator @leangseu-edx
Hi folks, could you help us with a review in his PR or help us identify the right reviewer?
Hi @arbrandes thank you for your review and not 100% sure to understand your request because when I used the branch I realized that the reason why the test didn't catch the errors was because the testing for this component and function was correct: Field.Text test and subsectionGrade test only the reference was not updated and not fail because of the use of jest.mock
.
I updated the test reference too, or I just can think of using the original component instead of mocking it but that does not make the test fail only displays a console.error
Yeah, it might be going overboard to test for this retroactively, here. I feel like it would initiate a full revamp, which would probably be better planned elsewhere. (As part of the migration to react-testing-library, perhaps.) Let's just fix the glaring issue and move on, for now.
@dcoa 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description The master branch doesn't have the references to new Field.Text updated, there is a screenshot of the error
As well
useGradeButtonData
doesn't return a string in the label field is returning a function, so the numbers weren't renderThis PR tries to solve that rendering situation.
What changed?
Developer Checklist
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora