openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

fix: add limited_staff to allowedRoles [BB-7834] #352

Closed 0x29a closed 1 year ago

0x29a commented 1 year ago

Description

Users with the Course Limited Staff role, that has been added here, don't have access to the gradebook. In this PR we add this role's slug to allowedRoles.

Testing instructions

The fix is pretty trivial, so just make sure that the slug in allowedRoles is equal to CourseLimitedStaffRole.ROLE value.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e96dbf) 94.93% compared to head (1514774) 94.93%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #352 +/- ## ======================================= Coverage 94.93% 94.93% ======================================= Files 139 139 Lines 1343 1343 Branches 264 264 ======================================= Hits 1275 1275 Misses 60 60 Partials 8 8 ``` | [Files Changed](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [src/data/thunkActions/roles.js](https://app.codecov.io/gh/openedx/frontend-app-gradebook/pull/352?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-c3JjL2RhdGEvdGh1bmtBY3Rpb25zL3JvbGVzLmpz) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openedx-webhooks commented 1 year ago

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.