openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

fix: fix sidebar scrolling and adaptation for mobile #362

Closed ihor-romaniuk closed 7 months ago

ihor-romaniuk commented 1 year ago

TL;DR -

This pull request contains minor fixes related to the responsiveness of the blocks for mobile phones. All the before and after screenshots are below.

Related Pull Requests PR to the master branch: https://github.com/openedx/frontend-app-gradebook/pull/363 PR to the open-release/quince.master branch: https://github.com/openedx/frontend-app-gradebook/pull/370

What changed?

Before After
image image
Before After
image image
image image
Before After
image image
Before After
image image
Before After
image image

Developer Checklist

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

FYI: @openedx/content-aurora

openedx-webhooks commented 1 year ago

Thanks for the pull request, @ihor-romaniuk! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/palm.master@3644172). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/palm.master #362 +/- ## ============================================================ Coverage ? 100.00% ============================================================ Files ? 122 Lines ? 1269 Branches ? 251 ============================================================ Hits ? 1269 Misses ? 0 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 7 months ago

Apologies for the ping @arbrandes , it looks like this needs product review.

jmakowski1123 commented 7 months ago

These fixes look great, thanks for contributing! This has product review.

openedx-webhooks commented 7 months ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.