Lytvynenko/grade field validation master

openedx / frontend-app-gradebook

Instructor grade book tool

GNU Affero General Public License v3.0

11 stars 87 forks source link

Lytvynenko/grade field validation master #364

Closed Inferato closed 9 months ago

Inferato commented 1 year ago

TL;DR - added simple validation for the "Adjusted grade" field in the "Edit Grades" popup:

enter only a numeric value
setting the minimum value
checking the correctness of the entered value to possibleGrade

Related: open-release/quince.master

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

[ ] I've done a visual code review
[ ] I've tested the new functionality

FYI: @openedx/content-aurora

openedx-webhooks commented 1 year ago

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

e0d commented 1 year ago

@Inferato looks like there are some test failures.

mphilbrick211 commented 12 months ago

@Inferato looks like there are some test failures.

Hi @Inferato! Flagging this for you :)

mphilbrick211 commented 11 months ago

Hi @Inferato - flagging the failing check here. Thanks!

mphilbrick211 commented 10 months ago

Hi @Inferato - flagging the failing check here. Thanks!

Hi @Inferato - just following up on this!

dyudyunov commented 9 months ago

@e0d @mphilbrick211

Sorry for the delays, Taras is no longer a member of RG. Currently, I'm gathering all the PRs he worked on. I will check their statuses and update them if necessary.

I will leave the status update comments on each PR's comments ASAP

dyudyunov commented 9 months ago

@e0d @mphilbrick211 could you close this PR in favor of https://github.com/openedx/frontend-app-gradebook/pull/382?

I updated the snapshot and increased the test coverage there

mphilbrick211 commented 9 months ago

Closing per comment above.

openedx-webhooks commented 9 months ago

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks commented 9 months ago

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.