openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: Assignment and course grade fields validations (quince.master) #367

Open vladislavkeblysh opened 1 year ago

vladislavkeblysh commented 1 year ago

Screenshot 2023-10-21 at 15 02 27 Screenshot 2023-10-21 at 15 02 42

openedx-webhooks commented 1 year ago

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/quince.master@b536180). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/quince.master #367 +/- ## ============================================================= Coverage ? 95.05% ============================================================= Files ? 140 Lines ? 1375 Branches ? 274 ============================================================= Hits ? 1307 Misses ? 60 Partials ? 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 1 year ago

Hi @openedx/content-aurora! This is ready for review/merge after the Master is all set.

farhaanbukhsh commented 5 months ago

@mphilbrick211 @arbrandes can I take this review?

mphilbrick211 commented 5 months ago

@mphilbrick211 @arbrandes can I take this review?

Hi @farhaanbukhsh! Please do!

farhaanbukhsh commented 3 months ago

@mphilbrick211 reviewing the one against master.