openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

fix: file input handler #371

Closed DmytroAlipov closed 12 months ago

DmytroAlipov commented 1 year ago

This is a backport from the master branch.

hasFile run only once, it will always be null

Знімок екрана 2023-10-27 о 17 33 46
openedx-webhooks commented 1 year ago

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (open-release/palm.master@3644172). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/palm.master #371 +/- ## ============================================================ Coverage ? 100.00% ============================================================ Files ? 122 Lines ? 1268 Branches ? 249 ============================================================ Hits ? 1268 Misses ? 0 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 1 year ago

Hi @openedx/content-aurora! I think this is ready for merge, the master has already been merged.

cmltaWt0 commented 12 months ago

Looked through the diff - looks exactly the same as for master. Seems safe to merge. Merging.

openedx-webhooks commented 12 months ago

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.