search

openedx / frontend-app-gradebook

Instructor grade book tool
GNU Affero General Public License v3.0
11 stars 87 forks source link

feat: adjusted grade field validation #381

Closed dyudyunov closed 1 week ago

dyudyunov commented 9 months ago

Description

Added simple validation for the "Adjusted grade" field in the "Edit Grades" popup:

Notes

This was already merged in nutmeg and maple, but the PR to the master branch wasn't open at that time.

The same PR was opened for the master branch https://github.com/openedx/frontend-app-gradebook/pull/382

Steps to reproduce

  1. Go to Instructor -> Student admin -> View Gradebook
  2. Click on any user
  3. In the Adjusted grade field fill in symbols, letters, a large number

Behaviour before the fix

Entering the large number has no errors and it's possible to save the incorrect value: image image

Entering text/special symbols results in 500 errors for the request: image image

openedx-webhooks commented 9 months ago

Thanks for the pull request, @dyudyunov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @farhaanbukhsh. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.02%. Comparing base (ba9fb37) to head (3565486). Report is 5 commits behind head on open-release/quince.master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## open-release/quince.master #381 +/- ## ============================================================== + Coverage 94.98% 95.02% +0.03% ============================================================== Files 140 140 Lines 1356 1366 +10 Branches 264 269 +5 ============================================================== + Hits 1288 1298 +10 Misses 60 60 Partials 8 8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

farhaanbukhsh commented 7 months ago

@mphilbrick211 I can help with review on this PR.

mphilbrick211 commented 7 months ago

@mphilbrick211 I can help with review on this PR.

Thank you, @farhaanbukhsh!

farhaanbukhsh commented 3 months ago

@mphilbrick211 I will try to review the PR against master and then come back to this.

dyudyunov commented 1 week ago

Closed as outdated