search

openedx / frontend-app-learning

Front-end for the Open edX course experience, implemented using React and Paragon.
GNU Affero General Public License v3.0
46 stars 199 forks source link

Untranslatable strings #1193

Open ghassanmas opened 12 months ago

ghassanmas commented 12 months ago

The Following is a list of strings that are hardcoded, untranslatable

  1. View course in https://github.com/openedx/frontend-app-learning/blob/168ed1e184ccafa6e36e044d6e95429936672b9b/src/instructor-toolbar/InstructorToolbar.jsx#L78
  2. Specific Student... https://github.com/openedx/frontend-app-learning/blob/168ed1e184ccafa6e36e044d6e95429936672b9b/src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx#L99
  3. View this course as: https://github.com/openedx/frontend-app-learning/blob/168ed1e184ccafa6e36e044d6e95429936672b9b/src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx#L123
jciasenza commented 1 month ago

I can take this issue @arbrandes

jciasenza commented 1 month ago

@arbrandes Add message ids and add a file src/instructor-toolbar/messages.js image

Also modify the masquerade src/instructor-toolbar/masquerade-widget/MasqueradeWidget.jsx image

If you approve my changes I will push them, or if something needs to be modified let me know thanks !!! Atte Juan Carlos (Aulasneo)