fix: corrects typo in IFRAME_FEATURE_POLICY

rediris commented 1 month ago

This is a simple fix to the IFRAME_FEATURE_POLICY, wherein a comma was used instead of a semi-colon.

Refer to the following screencap of the console for the warnings:

openedx-webhooks commented 1 month ago

Thanks for the pull request, @rediris!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

bradenmacdonald commented 1 month ago

Thanks @rediris! Looks like we need a CLA from you before we can merge though; would you mind doing that?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.23%. Comparing base (6534347) to head (46271a3). Report is 2 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1500 +/- ## ======================================= Coverage 89.23% 89.23% ======================================= Files 317 317 Lines 5557 5557 Branches 1375 1376 +1 ======================================= Hits 4959 4959 Misses 582 582 Partials 16 16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rediris commented 3 weeks ago

Thanks @rediris! Looks like we need a CLA from you before we can merge though; would you mind doing that?

@bradenmacdonald the individual contribution CLA should be all set. Hopefully the folks at axim can confirm.

bradenmacdonald commented 3 weeks ago

FYI @feanil @gabor-boros - this is just a typo fix so not changing the intended specs of this security policy, but I want to give you a heads up before merging because it says "Changes to it should be vetted by" the security WG.

bradenmacdonald commented 2 weeks ago

Thanks for the fix, @rediris !

openedx / frontend-app-learning