Clock icon in courseware sidebar does not follow conventions for notifications

openedx / frontend-app-learning

Front-end for the Open edX course experience, implemented using React and Paragon.

GNU Affero General Public License v3.0

46 stars 207 forks source link

Clock icon in courseware sidebar does not follow conventions for notifications #1509

Open aphilipharrell opened 3 weeks ago

aphilipharrell commented 3 weeks ago

The clock icon in the courseware sidebar leads to a Notifications window - the clock icon is misleading and this should be replaced with something more commonly understood to represent notifications.

Suggested fix:

Replace WatchOutline with Notifications in src/courseware/course/sidebar/sidebars/notifications/NotificationIcon.jsx

jciasenza commented 3 weeks ago

@arbrandes I assign it to myself

jciasenza commented 3 weeks ago

Hello aphilipharrell, I already made the PR

https://github.com/openedx/frontend-app-learning/pull/1510

angonz commented 2 weeks ago

@crathbun428 Can you please check if this request can be implemented? We can do it if approved.

crathbun428 commented 4 days ago

@angonz - There is potentially going to be some work done on the right-sidebar soon. I think thinking through what icons are shown will be apart of this work. I want to check in with @brian-smith-tcril and @jmakowski1123 to make sure I have this right.