search

openedx / frontend-app-learning

Front-end for the Open edX course experience, implemented using React and Paragon.
GNU Affero General Public License v3.0
46 stars 207 forks source link

fix: Replace WatchOutline with Notifications #1509 #1510

Open jciasenza opened 3 weeks ago

jciasenza commented 3 weeks ago

#1509

What changed? Replace WathOutline icon with notifications it looks more aesthetic

image

Screenshot from 2024-11-01 15-43-47

And Testing OK

If something needs to be modified, let me know, thank you!!! Atte Juan Carlos (Aulasneo)

Developer Checklist

Test suites passing Documentation and test plan updated, if applicable Received code-owner approving review

openedx-webhooks commented 3 weeks ago

Thanks for the pull request, @jciasenza!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.25%. Comparing base (c20c767) to head (0b04c50).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1510 +/- ## ======================================= Coverage 89.25% 89.25% ======================================= Files 318 318 Lines 5563 5563 Branches 1379 1379 ======================================= Hits 4965 4965 + Misses 583 582 -1 - Partials 15 16 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 2 weeks ago

@jciasenza Thank you for this contribution!

We have a green build here so I'm marking this PR as ready for review. (Let us know if you had plans to continue working on the changes before putting them up for review, though.)

jciasenza commented 2 weeks ago

itsjeyd I think it would be ready so they can merge it

bradenmacdonald commented 2 weeks ago

@jciasenza Thank you for the contribution. @itsjeyd This looks great from my perspective but shouldn't we get a product +1 since it's a UX change?

angonz commented 2 weeks ago

@jciasenza Thank you for the contribution. @itsjeyd This looks great from my perspective but shouldn't we get a product +1 since it's a UX change?

I asked Chelsea in the original issue to look at it.

itsjeyd commented 1 week ago

@bradenmacdonald @jciasenza Sounds good re: getting product approval.