feat!: remove Transifex calls for OEP-58

hopewise commented 1 year ago

Breaking change!

This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

Removes all direct use of tx pull and tx push commands from the micro-frontend in favor of the atlas pull command.
Remove source and language translations from the repositories, hence no .json files will be committed into the repos.
src/i18n/index.js should export and empty array so the make pull_translations override it with the dynamic list of languages.
Remove all Transifex related Makefile targets and other files.

Test results

[ ] Verify that make extract_translations works as expected.

make extract_translations test results

``` # I've run the following commands: $ make requirements $ make pull_translations $ git diff # Output of the commmands: make extract_translations npm ci npm WARN prepare removing existing node_modules/ before installation > @fortawesome/fontawesome-common-types@6.4.2 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/@fortawesome/fontawesome-common-types > node attribution.js Font Awesome Free 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) Copyright 2023 Fonticons, Inc. > @fortawesome/free-solid-svg-icons@6.4.2 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/@fortawesome/free-solid-svg-icons > node attribution.js Font Awesome Free 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) Copyright 2023 Fonticons, Inc. > @fortawesome/free-regular-svg-icons@6.4.2 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/@fortawesome/free-regular-svg-icons > node attribution.js Font Awesome Free 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) Copyright 2023 Fonticons, Inc. > @fortawesome/free-brands-svg-icons@6.4.2 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/@fortawesome/free-brands-svg-icons > node attribution.js Font Awesome Free 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) Copyright 2023 Fonticons, Inc. > @fortawesome/fontawesome-svg-core@6.4.2 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/@fortawesome/fontawesome-svg-core > node attribution.js Font Awesome Free 6.4.2 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) Copyright 2023 Fonticons, Inc. > sharp@0.32.6 install /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/sharp > (node install/libvips && node install/dll-copy && prebuild-install) || (node install/can-compile && node-gyp rebuild && node install/dll-copy) sharp: Using cached /Users/sadaftech/.npm/_cacache/_libvips/libvips-8.14.5-darwin-x64.tar.br sharp: Integrity check passed for darwin-x64 > core-js@2.6.12 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/core-js > node -e "try{require('./postinstall')}catch(e){}" > core-js-pure@3.33.2 postinstall /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/node_modules/core-js-pure > node -e "try{require('./postinstall')}catch(e){}" added 1966 packages in 31.509s # Pulling display strings from .jsx files into .json files... rm -rf ./temp/babel-plugin-formatjs npm run-script i18n_extract > @edx/frontend-component-footer@1.0.0-semantically-released i18n_extract /Users/sadaftech/Documents/zeit-labs/frontend-component-footer > fedx-scripts formatjs extract Running with resolved config: /Users/sadaftech/Documents/zeit-labs/frontend-component-footer/babel.config.js # Gathering JSON messages into one file... ./node_modules/.bin/transifex-utils.js ./temp/babel-plugin-formatjs ./src/i18n/transifex_input.json ```

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

Keep this pull request as a draft to prevent accidental merge.

Pre-merge checklist

[ ] Wait for approval on https://github.com/openedx/wg-translations/issues/20

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @hopewise! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

e0d commented 1 year ago

@hopewise looks like there are some test failures.

hopewise commented 1 year ago

a new line added to the src/i18n/index.js, to allow test to pass.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.74%. Comparing base (5c0ac3d) to head (97e7abe). Report is 15 commits behind head on master.

:exclamation: Current head 97e7abe differs from pull request most recent head dcb7e05. Consider uploading reports for the commit dcb7e05 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #355 +/- ## ========================================== + Coverage 89.09% 90.74% +1.64% ========================================== Files 6 5 -1 Lines 55 54 -1 Branches 18 18 ========================================== Hits 49 49 + Misses 6 5 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

OmarIthawi commented 8 months ago

@timmc-edx this one is ready but pending 2U approval.

cc: @brian-smith-tcril

OmarIthawi commented 7 months ago

@brian-smith-tcril rebased.

OmarIthawi commented 7 months ago

@brian-smith-tcril rebased :)

openedx-webhooks commented 7 months ago

@hopewise 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx / frontend-component-footer