openedx / frontend-component-footer

Site footer component for edX frontend apps.
GNU Affero General Public License v3.0
6 stars 97 forks source link

[BD-46] feat: added start:with-theme script #378

Closed PKulkoRaccoonGang closed 11 months ago

PKulkoRaccoonGang commented 11 months ago

Description

Added application start script with the ability to install the required theme (default @openedx/brand-openedx@latest). After interrupting a running process, the topic is automatically removed from the node_modules directory.

Related to: https://github.com/openedx/paragon/issues/2831

openedx-webhooks commented 11 months ago

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (fc3c958) 89.09% compared to head (ea74f2d) 89.09%. Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #378 +/- ## ======================================= Coverage 89.09% 89.09% ======================================= Files 6 6 Lines 55 55 Branches 18 18 ======================================= Hits 49 49 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

viktorrusakov commented 11 months ago

@PKulkoRaccoonGang This is not an MFE, it's just a package that exports some components, I don't think npm start even works here, so we don't need to add this script.

edit: I didn't see there is an example MFE in the repo, then it makes sense to add this script