search

openedx / frontend-component-footer

Site footer component for edX frontend apps.
GNU Affero General Public License v3.0
6 stars 97 forks source link

test: Remove support for Node 18 #472

Closed BilalQamar95 closed 1 week ago

BilalQamar95 commented 1 month ago

Description

Completed upgrade to Node 20 by removing the Node 18 CI check and using .nvmrc for version to use.

See the tracking issue for further information.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.22%. Comparing base (906d9a7) to head (7176d01). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #472 +/- ## ======================================= Coverage 91.22% 91.22% ======================================= Files 5 5 Lines 57 57 Branches 19 19 ======================================= Hits 52 52 Misses 5 5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

brian-smith-tcril commented 1 month ago

These changes look great! I'm going to hold off on merging this along with all other PRs dropping Node 18 until Sumac is cut as per https://github.com/openedx/public-engineering/issues/280