Open asadali145 opened 7 months ago
Thanks for the pull request, @asadali145!
Please work through the following steps to get your changes ready for engineering review:
If you haven't already, check this list to see if your contribution needs to go through the product review process.
To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
This PR must be merged before / after / at the same time as ...
This PR is waiting for OEP-1234 to be accepted.
This PR must be merged by XX date because ...
This is for a course on edx.org.
If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.
This repository is currently unmaintained.
To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
Our goal is to get community contributions seen and reviewed as efficiently as possible.
However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.
Attention: Patch coverage is 93.75000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 67.71%. Comparing base (
45246ad
) to head (35287fc
). Report is 3 commits behind head on master.:exclamation: Current head 35287fc differs from pull request most recent head d5227d4. Consider uploading reports for the commit d5227d4 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/Header.jsx | 88.88% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @asadali145! Would you mind resolving the branch conflicts while I look for someone to review for you? Thanks!
@mphilbrick211 This should be good for a review now.
@arbrandes What are your thoughts on this PR? It is similar to the footer PR https://github.com/openedx/frontend-component-footer/pull/403 related to https://github.com/openedx/platform-roadmap/issues/324
@asadali145, the latest on this is that we'll be addressing header configurability as part of the OEP-65/Module Federation work. For the most part, it will be done as proposed here:
https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4412243977/Proposal+Customizable+Header+for+LMS
In the meantime, we're also adding PluginSlots to the header, such as this one.
https://github.com/openedx/frontend-component-header/pull/528
The slots should be ready by Sumac.
@asadali145 should we pursue this via the header pluginslot instead of configuration settings?
@asadali145 should we pursue this via the header pluginslot instead of configuration settings?
@pdpinch I don't think there is much that I can do at the moment per this comment on my footer PR
My recommendation would be for us to add plugin slots to the header/footer to support customization use cases for now, I think @brian-smith-tcril is helping with this effort.
As the comment @asadali145 linked mentions, we're working on a longer-term version of the header and footer which will support more customization through simple configuration. That's taking some time to get right, and won't be available for a while. Certainly not by Sumac, maybe by Teak.
Issue
https://github.com/openedx/platform-roadmap/issues/349
Description
Makes header links, labels, and User name display more customizable using the configurations.
Testing
SHOW_FULLNAME=true
DASHBOARD_URL=<ANY URL>
EXTERNAL_ACCOUNT_PROFILE_URL=<ANY URL>
SHOW_SETTINGS_LABEL=true
ACCOUNT_SETTINGS_URL=http://localhost:1997
Screenshots