fix: provide onClick feature in configurable headers

openedx / frontend-component-header

GNU Affero General Public License v3.0

7 stars 123 forks source link

fix: provide onClick feature in configurable headers #494

Closed ahtesham-quraish closed 6 months ago

ahtesham-quraish commented 6 months ago

Description:

Provide onClick facility for all of menus kind
Sometime we need the additional onClick functionality in MFEs like in following learner dashboard we need this

JIRA VAN-1914

ahtesham-quraish commented 6 months ago

Not disapproving in principle - it's fine to add an onClick prop - but I would like to understand the null thing.

In some cases we will not be passing onClick event in that case we just passing null so app does not get crashed or any error does not come. There won't any case where it would be '' or 0

arbrandes commented 6 months ago

Oops. This should've been a feat, I believe. Not worth fixing now, though. Let's just live with it.