search

openedx / frontend-component-header

GNU Affero General Public License v3.0
7 stars 123 forks source link

feat: expose containerProps in StudioHeader [FC-0062] #529

Closed rpenido closed 1 month ago

rpenido commented 2 months ago

Description

This PR adds a new boolean containerProps property to the StudioHeader component. This property will be passed downstream to the Container component in the Header, allowing the user to override the Container props (i.e. changing the max size).

More information

Part of:

Depends on:

Private ref: FAL-3820

openedx-webhooks commented 2 months ago

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.55%. Comparing base (e44001e) to head (61243f4). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #529 +/- ## ========================================== + Coverage 70.47% 70.55% +0.08% ========================================== Files 25 25 Lines 359 360 +1 Branches 94 95 +1 ========================================== + Hits 253 254 +1 Misses 104 104 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adamstankiewicz commented 1 month ago

[inform] It looks like the example MFE application in this repo is broken on the latest version of @openedx/frontend-build, i.e. running npm start results in a blank screen running on localhost:8080. See this PR for a fix to get the example running again, which should make local development within this repo easier by relying on the example app: https://github.com/openedx/frontend-component-header/pull/531

rpenido commented 1 month ago

Hi @adamstankiewicz! Could you do a review/merge here when you have some time? Thank you!

bradenmacdonald commented 1 month ago

@adamstankiewicz we need to ship some features that this is blocking - did you have any further concerns here? If your plate is full I can do a review+merge - but I just want to make sure you don't have any unaddressed concerns.