feat: Fixed delete for additional video url fields

vladislavkeblysh commented 1 year ago

Fixed delete for additional video url fields

Screenshot 2023-11-05 at 14 38 46

openedx-webhooks commented 1 year ago

Thanks for the pull request, @vladislavkeblysh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

mphilbrick211 commented 11 months ago

Hi @vladislavkeblysh! Looks like there's a failing check - would you mind taking a look?

vladislavkeblysh commented 10 months ago

@mphilbrick211 Fixed

mphilbrick211 commented 10 months ago

@mphilbrick211 Fixed

There's still a failing check - let me know if you're having issues clearing it, and I can look into it for you. Thanks!

mphilbrick211 commented 8 months ago

@mphilbrick211 Fixed

There's still a failing check - let me know if you're having issues clearing it, and I can look into it for you. Thanks!

Friendly ping on this, @vladislavkeblysh!

mphilbrick211 commented 7 months ago

Hi @vladislavkeblysh! Just checking in to see if you plan to pursue this pull request? If not, we can close for now and reopen at a later time.

vladislavkeblysh commented 7 months ago

@mphilbrick211 still in progress, will be fixed soon, ty

vladislavkeblysh commented 6 months ago

@mphilbrick211 Fixed

mphilbrick211 commented 6 months ago

Hi @openedx/2u-tnl! This is ready for review.

KristinAoki commented 4 months ago

@vladislavkeblysh in the description can you put a more in depth description of the bug that is being fixed?

mphilbrick211 commented 4 months ago

@vladislavkeblysh in the description can you put a more in depth description of the bug that is being fixed?

@vladislavkeblysh - friendly follow-up on this!

KristinAoki commented 2 months ago

Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to frontend-app-course-authoring. If you would like your work to be included in the transition please resolve outstanding requests for this PR. This PR will automatically close once frontend-app-course-authoring PR #1208 is merged.

bradenmacdonald commented 2 months ago

As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against frontend-app-course-authoring if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local content-components repo as a remote in course-authoring, then pull the branch and rebase it).

openedx-webhooks commented 2 months ago

@vladislavkeblysh Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

mphilbrick211 commented 2 months ago

As mentioned above, we've now moved this code into https://github.com/openedx/frontend-app-course-authoring/ so we'll need you to please re-open this PR against frontend-app-course-authoring if you'd like to continue it. Feel free to reach out to me if you aren't sure how to do that using git and I can help (basically: add your local content-components repo as a remote in course-authoring, then pull the branch and rebase it).

@vladislavkeblysh

openedx / frontend-lib-content-components