openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

fix: add rtl support to editor #424

Closed ihor-romaniuk closed 3 months ago

ihor-romaniuk commented 11 months ago

TL;DR -

This pull request contains feature of dynamically adaptation to RLT or LTR side direction.

What changed?

Before After
image image
openedx-webhooks commented 11 months ago

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.56%. Comparing base (57042c9) to head (c32f30e). Report is 66 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #424 +/- ## ======================================= Coverage 90.55% 90.56% ======================================= Files 227 227 Lines 4120 4122 +2 Branches 831 832 +1 ======================================= + Hits 3731 3733 +2 Misses 369 369 Partials 20 20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 11 months ago

Hi @ihor-romaniuk! Just flagging that some branch conflicts have popped up.

ihor-romaniuk commented 11 months ago

Hi @mphilbrick211! Resolved, thanks.

mphilbrick211 commented 11 months ago

@openedx/teaching-and-learning this is all set for review!

mphilbrick211 commented 8 months ago

@openedx/2u-tnl - would someone be able to please review / merge this for us?

mphilbrick211 commented 7 months ago

Hi @openedx/2u-tnl! Would someone be able to please review / merge this for us? Thanks!

openedx-webhooks commented 3 months ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.