openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

fix: add validation to problem number fields #425

Closed ihor-romaniuk closed 3 months ago

ihor-romaniuk commented 11 months ago

Description:

This pull request contains fixes to problem number fields Scoring point (weight), Scoring attempts, Show answer, Time between attempts and Tolerance.

According to old (legacy) studio functionality were changed:

Screenshots:

image
openedx-webhooks commented 11 months ago

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.50%. Comparing base (c0bc54a) to head (44dc0b7). Report is 79 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #425 +/- ## ======================================= Coverage 90.49% 90.50% ======================================= Files 228 228 Lines 4115 4118 +3 Branches 822 823 +1 ======================================= + Hits 3724 3727 +3 Misses 370 370 Partials 21 21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mphilbrick211 commented 8 months ago

HI @openedx/2u-tnl! Would someone be able to please review / merge this for us?

mphilbrick211 commented 7 months ago

Hi @openedx/2u-tnl! Would someone be able to take a look at this? Thanks!

openedx-webhooks commented 3 months ago

@ihor-romaniuk 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.