openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

fix: license widget checkbox and link #486

Closed khudym closed 3 months ago

khudym commented 4 months ago

Description

Steps to reproduce

Basic setup Go to studio -> unit -> Video block -> scroll to the end of editors page and click on the "Add a license for this video" button.

  1. "Share alike" issue:

basic setup -> in the "License type" field select "Creative Commons" -> Check Share alive (No derivatives unchecked) -> save -> open for edit again

ACTUAL RESULT: Share Alike option is displayed as unchecked

share_alike_AC

EXPECTED RESULT: Share Alike option is displayed as checked

License_widget_sharealike

  1. "View license details link" issue:

basic setup -> in the "License type" field select "All Rights Reserved".

ACTUAL RESULT: View license details with link to https://creativecommons.org/about/ is displayed below

EXPECTED RESULT: this link only displayed for Creative Commons license type

all_rights_reserved_no_link
openedx-webhooks commented 4 months ago

Thanks for the pull request, @khudym! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.92%. Comparing base (6a58779) to head (65eefec). Report is 20 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #486 +/- ## ========================================== + Coverage 88.84% 88.92% +0.07% ========================================== Files 248 248 Lines 4529 4540 +11 Branches 928 943 +15 ========================================== + Hits 4024 4037 +13 + Misses 474 470 -4 - Partials 31 33 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openedx-webhooks commented 3 months ago

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.