openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

Revert "feat: improve asset loading" #488

Closed bszabo closed 4 months ago

bszabo commented 4 months ago

Reverts openedx/frontend-lib-content-components#484

Is causing failures with course updates per CR, as identified by Kristin Aoki, the author of the original PR:

The Course Authoring page is loading an Unexpected Application Error! when licking into the edit button on the welcome page.

This has happened on both Firefox and Google Chrome.

It is supposed to be opening the page for text input.

Steps to reproduce:

Using Chrome, Open into Studio and find the course

Course link: https://studio.edx.org/course/course-v1:RaspberryPiFoundation+RPFAITeachers+2T2024

Click into the “5/9 completed” checklist link:

Click into the Update button next to “Add a welcome message”

Click into “+ Add first update

Results: Unexpected Application Error! (screenshot attached)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 93.81443% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (c84e322) to head (ba8141e).

Files Patch % Lines
...rc/editors/sharedComponents/TinyMceWidget/hooks.js 90.90% 5 Missing :warning:
src/editors/containers/ProblemEditor/index.jsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #488 +/- ## ========================================== + Coverage 88.86% 89.20% +0.33% ========================================== Files 248 246 -2 Lines 4534 4510 -24 Branches 933 927 -6 ========================================== - Hits 4029 4023 -6 + Misses 474 456 -18 Partials 31 31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.