openedx / frontend-lib-content-components

[Moved to openedx/frontend-app-course-authoring] A library of high-level components for content handling (viewing, editing, etc. of HTML, video, problems, etc.), to be shared by multiple MFEs.
GNU Affero General Public License v3.0
11 stars 33 forks source link

feat: remove offset when studio header exists #491

Closed khudym closed 4 months ago

khudym commented 4 months ago

Description

Before

Schedule & details page

Знімок екрана 2023-12-19 о 14 12 40

Course updates page

Знімок екрана 2024-01-02 о 14 20 10

After

Schedule & details page

Screenshot 2024-07-04 at 20 13 12

Course updates page

Screenshot 2024-07-04 at 20 12 07
openedx-webhooks commented 4 months ago

Thanks for the pull request, @khudym! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.92%. Comparing base (c84e322) to head (ccbe859). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #491 +/- ## ========================================== + Coverage 88.86% 88.92% +0.05% ========================================== Files 248 248 Lines 4534 4540 +6 Branches 933 940 +7 ========================================== + Hits 4029 4037 +8 + Misses 474 470 -4 - Partials 31 33 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

openedx-webhooks commented 4 months ago

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.